search

treasure-data / serverengine

A framework to implement robust multiprocess servers like Unicorn
Apache License 2.0
759 stars 86 forks source link

fix for issue #74, set gid before uid #75

Closed neurogenesis closed 8 years ago

neurogenesis commented 8 years ago

In response to #74 ...

This switches the order of setting GID with UID.

If the UID is set first, the process doesn't have permissions to modify GID.

This would be the case when run via sudo /usr/local/bin/fluentd -d -u fluentd -g fluentd ....

repeatedly commented 8 years ago

It seems good. Fluentd v0.12 or earlier uses same order.

tagomoris commented 8 years ago

LGTM.

neurogenesis commented 8 years ago

Many thanks!

Any idea when the next patch release for the gem will be out? Hoping to push fluentd clients out with the privilege changes for prod.

tagomoris commented 8 years ago

I will do it later. Wait for a minute.

neurogenesis commented 8 years ago

Also, likely related to https://github.com/fluent/fluentd/issues/1195.

tagomoris commented 8 years ago

I've just released v2.0.1. Thank you for your contribution!

neurogenesis commented 8 years ago

Super fast turnaround. Thanks @tagomoris. Up and running!