Fix busy loop on windows

treasure-data / serverengine

A framework to implement robust multiprocess servers like Unicorn

Apache License 2.0

759 stars 86 forks source link

Fix busy loop on windows #77

Closed tagomoris closed 7 years ago

tagomoris commented 8 years ago

Fixes #76.

tagomoris commented 8 years ago

@unak Could you check this diff? And, I think heartbeat can be enabled also on Windows platform. Do you have any idea about any barrier to make it enabled? https://github.com/treasure-data/serverengine/blob/master/lib/serverengine/process_manager.rb#L173

unak commented 8 years ago

@tagomoris I'll check it. Just a moment...

BTW, Ruby on Windows cannot pass pipes (and any IOs) via file descriptors excepts 0, 1 or 2. Therefore, we need another mechanism to tell the child processes the heartbeat pipes to enable it.

tagomoris commented 8 years ago

@unak I see about it. Thank you for quick comment.

tagomoris commented 7 years ago

@unak ping?

unak commented 7 years ago

Oh, sorry, I've forgotten to reply. My conclusion is that it looks good.

tagomoris commented 7 years ago

Merged. Thank you @unak!