signal: Don't ignore SIGDUMP_SIGNAL environment variable

treasure-data / serverengine

A framework to implement robust multiprocess servers like Unicorn

Apache License 2.0

759 stars 86 forks source link

signal: Don't ignore SIGDUMP_SIGNAL environment variable #97

Closed repeatedly closed 5 years ago

repeatedly commented 5 years ago

sigdump provides SIGDUMP_SIGNAL environment variable to change the target signal. serverengine now ignores this value so even if the user sets SIGDUMP_SIGNAL, serverengine still dumps sigdump result by CONT. This is unexpected behaviour.

repeatedly commented 5 years ago

Is there any reason why the environment variable should have the same name as sigdump's one?

Do you mean serverengine should have other name for dump like SERVERENGINE_DUMP_SIGNAL? Currently, serverengine's dump is for sigdump so users think SIGDUMP_SIGNAL changes trap signal for sigump.