search

treasure-data / td-client-python

Treasure Data API library for Python
Apache License 2.0
47 stars 24 forks source link

Disabled coveralls #103

Closed myui closed 3 years ago

myui commented 3 years ago

Disabled coverall to avoid 

Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs

follow up to #102

myui commented 3 years ago

@chezou could you take a look?

chezou commented 3 years ago

Change itself looks good to me.

However I'm not an active maintainer of this project as well, and I don't know the historical things for coverall so that I'd like for @yyuu to ask to have another look at this.

chezou commented 3 years ago

@yyuu Thanks for having time for another review. Apologies I totally forgot to approve the PR with my previous comment.

For an alternative instead of coveralls, codecov looks like good to start with github actions https://about.codecov.io/blog/python-code-coverage-using-github-actions-and-codecov/

myui commented 3 years ago

Thanks, disable coveralls for the time being.