search

treasure-data / td

CUI Interface
https://toolbelt.treasuredata.com
49 stars 26 forks source link

Update Import/Workflow Endpoint Configurations #229

Open tagomoris opened 4 years ago

tagomoris commented 4 years ago

To have default values supposed from default endpoint value, and also to allow to override those endpoints via command-line options.

In order to realize those things, I added some internal classes. Because the former way to manage configuration values requires to add many class variables and methods (like cl_*), and it is really messy & uncontrollable. So, this change is a little larger than I expected. I want to hear the reviewers' comments.

tagomoris commented 4 years ago

Oh, no... I'll fix the failing tests later (it's only about workflow)

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.3%) to 52.85% when pulling bc6c7197a5fc7a1f104ccee574858fd11daa7711 on update-configuration-classes into c06cde6a70d8a80847e72c5f253fcdf9c7019e28 on master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.01%) to 52.545% when pulling 693835d25387da84b02ea447778774afc69114ae on update-configuration-classes into c06cde6a70d8a80847e72c5f253fcdf9c7019e28 on master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.01%) to 52.545% when pulling 693835d25387da84b02ea447778774afc69114ae on update-configuration-classes into c06cde6a70d8a80847e72c5f253fcdf9c7019e28 on master.

tagomoris commented 4 years ago

Added a change to fix CI failures. @nurse could you look on this?