search

treasure-data / td

CUI Interface
https://toolbelt.treasuredata.com
49 stars 26 forks source link

Increase the summary_width value to fix the broken options help message format #248

Closed kwangshin closed 3 years ago

kwangshin commented 3 years ago

The summary width of --assume-role option in table:export help message is exceeding the current default value (32), so the help message for --assume-role option is broken.

# td table:export
usage:
  $ td table:export <db> <table>

......

  -e, --encryption ENCRYPT_METHOD  export with server side encryption with the ENCRYPT_METHOD
  -a ASSUME_ROLE_ARN,              export with assume role with ASSUME_ROLE_ARN as role arn
      --assume-role

To fix the broken help message for --assume-role option, we need to increase the summary width. From here, we increase the value to 36. After increasing the summary width, we can see the proper help message for --assume-role option as the following:

# td table:export
usage:
  $ td table:export <db> <table>

......

  -e, --encryption ENCRYPT_METHOD      export with server side encryption with the ENCRYPT_METHOD
  -a, --assume-role ASSUME_ROLE_ARN    export with assume role with ASSUME_ROLE_ARN as role arn
kwangshin commented 3 years ago

The CircleCI tests have been failed...

The --keyserver has been changed, and new key server has "Host not found" error.

@treasure-data/integrations Could you please help to take a look?

Current Test Failure https://app.circleci.com/pipelines/github/treasure-data/td/36/workflows/1ff75fb0-4392-4d1c-9ace-8b78645f52e4/jobs/226

until gpg --keyserver hkp://ipv4.pool.sks-keyservers.net --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3 7D2BAF1CF37B13E2069D6956105BD0E739499BDB

......

gpg: requesting key D39DC0E3 from hkp server ipv4.pool.sks-keyservers.net
gpg: requesting key 39499BDB from hkp server ipv4.pool.sks-keyservers.net
?: ipv4.pool.sks-keyservers.net: Host not found
gpgkeys: HTTP fetch error 7: couldn't connect: Success
?: ipv4.pool.sks-keyservers.net: Host not found
gpgkeys: HTTP fetch error 7: couldn't connect: Success
gpg: no valid OpenPGP data found.

Previous PR with Test Success https://app.circleci.com/pipelines/github/treasure-data/td/35/workflows/f9aa4b38-4c99-461a-9410-133bfa03ed1a/jobs/221

until gpg --keyserver hkp://keyserver.ubuntu.com --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3 7D2BAF1CF37B13E2069D6956105BD0E739499BDB
kwangshin commented 3 years ago

@tung-vu-td Do you have any chance to review this PR? (As @kietdo360 requested a review to you. 😄 )

If it is merged, then usually how long does it take to release with new version? Do we have any upcoming plan for new version? (I'm sorry that I'm not familiar with release version strategy for this repository.)

tung-vu-td commented 3 years ago

Hi @kwangshin, The review will be fast since the PR is small. However let me look into the gpg keyserver failure as it need to be fixed in order for this PR to be merged. As for release, there is a release coming up soon.