search

treblereel / mapper-xml

j2cl/gwt compatible XML marshallers
Apache License 2.0
3 stars 3 forks source link

KOGITO-5534: Codegen should use (un)marshallers for XmlElement(Ref) type #87

Closed manstis closed 3 years ago

manstis commented 3 years ago

See https://issues.redhat.com/browse/KOGITO-5534

In essence I now check for the presence of @XmlElement or @XmlElementRef on fields when generating the serializer\deserializer. I also do a similar check when processing the fields on beans to ensure code is also generated for classes not annotated with @XmlMapper.

treblereel commented 3 years ago

@manstis very cool, thanks a million !

manstis commented 3 years ago

@treblereel Happy to help... it'd be great if you'd be able to release a newer version (with this fix) at some point.

treblereel commented 3 years ago

@manstis i think, i can switch jaxb to jakartaee and release all together, wdyt ?

manstis commented 3 years ago

@treblereel You could... but once the mapper-xml plugin is upgraded everyone that uses it will need to move too.

I'm more than happy to move my work to Jakarta however IDK if the DMN or BPMN teams would be affected?

If they are, then the move to Jakarta probably needs to be coordinated; or at least communicated.

treblereel commented 3 years ago

@manstis ok, let's wain for Roger...

manstis commented 3 years ago

@treblereel I'll send an email tomorrow.