search

treblereel / mapper-xml

j2cl/gwt compatible XML marshallers
Apache License 2.0
3 stars 3 forks source link

KOGITO-5669: PMML generated model has case sensitive classes #91

Closed manstis closed 3 years ago

manstis commented 3 years ago

See https://issues.redhat.com/browse/KOGITO-5669

@treblereel The second commit is the significant one for this PR.

When #90 is merged I'll rebase this one so it only includes the new PMML model (interfaces and classes).

I mentioned the other day that the PMML model you had in jre-tests was very old. This PR brings it bang up to date!

treblereel commented 3 years ago

@manstis 1071 new files, wow

@XmlValue exists here ./common/src/main/java/javax/xml/bind/annotation/XmlValue.java, do we need to have one more instance of it ?

manstis commented 3 years ago

@treblereel This has been rebased now and only includes the PMML model changes.

As discussed I've also moved the mocked/stubbed jaxb-api interfaces/classes to the common module.

manstis commented 3 years ago

@manstis 1071 new files, wow

Nope.. only 1,065 and they're not new as such but the "new" PMML model (replacing the old one you was using).

This "new" model is the beast that has been conjuring up the issues recently fixed.

manstis commented 3 years ago

Hi @treblereel I'm on vacation for a couple of weeks. It'd be nice if you're happy to merge this and release a new version of the plugin while I'm away :-)

manstis commented 3 years ago

Hi @treblereel is this something you want to merge?

It updates the test PMML model to the one actually being used so better demonstrates any future bugs we may encounter.

treblereel commented 3 years ago

@manstis let me check it once again and i merge