search

treblereel / mapper-xml

j2cl/gwt compatible XML marshallers
Apache License 2.0
3 stars 3 forks source link

KOGITO-5701: Failing test for XML attribute handled by XMLAdapter #93

Closed hasys closed 3 years ago

hasys commented 3 years ago

Hi @treblereel,

XMLAdapter is work only for node elements now, when I tried it for XMLAttributes, the annotation is ignored and field saved to XML as element.

This PR contains a test. When I execute it I am getting this result:

Results :

Failed tests:   testSerializeValue(org.treblereel.gwt.xml.mapper.client.tests.annotations.xmladapter.attribute.AttributeAdapterTest): expected:<...?><BeanWithAttribute[ value='test string']></BeanWithAttribute...> but was:<...?><BeanWithAttribute[><value>test value</value]></BeanWithAttribute...>

Tests in error: 
  testDeserializeValue(org.treblereel.gwt.xml.mapper.client.tests.annotations.xmladapter.attribute.AttributeAdapterTest): java.lang.UnsupportedOperationException
treblereel commented 3 years ago

@hasys Thank you, i ll take a look at it next monday

treblereel commented 3 years ago

possible fix in https://github.com/treblereel/mapper-xml/pull/95

hasys commented 3 years ago

Closing as fix with test provided in https://github.com/treblereel/mapper-xml/pull/95