trebleshot / android

An open-source app that allows you to transfer files one to one securely or using a browser, all without the internet
GNU General Public License v2.0
151 stars 42 forks source link

5GHz band #115

Open abdulhakam opened 4 years ago

abdulhakam commented 4 years ago

I was thinking there should be a button to toggle between 2.4ghz and 5ghz band for speed vs compatibility like the one I have seen Zapya.

PeterHindes commented 4 years ago

I want this even work this is based on the Wi-Fi network you're connected to isn't it. Or are you talking about the hotspot feature which is probably controlled by your phone's operating system.

mubashir-rehman commented 4 years ago

Most probably, the OP is talking about hotspot feature which might not be available in depending upon device and region.

mubashir-rehman commented 4 years ago

This might help a lot. https://github.com/VREMSoftwareDevelopment/WiFiAnalyzer/search?q=WiFi+band+toggle&unscoped_q=WiFi+band+toggle @velitasali Edit: Check this instead https://github.com/VREMSoftwareDevelopment/WiFiAnalyzer/search?q=WiFi+band+toggle&type=Commits (These commits have code for toggle along with tests.) Edit: I misunderstood the implementation. I thought that WiFi and Hotspot use same settings for band. I might still be right but above links show how to implement toggle for WiFi band.

velitasali commented 4 years ago

The problem is not whether this can be achieved. The problem is what will happen when the other device doesn't support that frequency.

kairusds commented 3 years ago

The problem is not whether this can be achieved. The problem is what will happen when the other device doesn't support that frequency.

If it doesn't, won't falling back to 2.4GHz by adding a compatibility check be a solution to this?

velitasali commented 3 years ago

@kairusds that is where the problem begins actually. If the frequency is not supported it will not show up on the scan results. Then, either we will rely on user support to ask the user if it did not show up or use third-party means, e.g. bluetooth, to collect info about the capabilities of devices.

kairusds commented 3 years ago

@velitasali the latter seems like a good choice or just disable the option entirely if the device does not support it.

velitasali commented 3 years ago

@kairusds That is not a feature atm (the app doesn't make use of Bluetooth by default). I will see what I can do.

kairusds commented 3 years ago

thanks for replying. I meant to say that you can disable the option for devices that don't support 5GHz WiFi instead if Bluetooth is not worth the hassle.

On Wed, Jul 28, 2021, 12:42 AM Veli Tasalı @.***> wrote:

@kairusds https://github.com/kairusds That is not a feature atm (the app doesn't make use of Bluetooth by default). I will see what I can do.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/trebleshot/android/issues/115#issuecomment-887666222, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHY745HJPIOBOZPPCYXCSHLTZ3OYPANCNFSM4LUSRCWQ .

mubashir-rehman commented 3 years ago

Just depend upon the user to manually change bands in system settings for now is a good option. Which seems to be the default behavior too.