Closed DSOTM-pf closed 3 years ago
Thanks for the thorough description.
The changes you are suggesting are already there in the latest revision.
Thanks for the thorough description.
The changes you are suggesting are already there in the latest revision.
Awesome! Very thanks!
Hi, there, I've found an issue in version 1.4.2, which is downloaded from F-Droid.
Describe the bug
I found the usage of
startLocalOnlyHotspot
may cause compatibility bugs. It is related to the call chain:This API needs
ACCESS_COARSE_LOCATION
permission at API-level 28 and below, but is changed toACCESS_FINE_LOCATION
in 29. The app only uses coarse location in the manifest.In API 28
In API 29
It can be fixed by adding fine location to the manifest, and request for the fine location at somewhere in the program (maybe before calling that API, and also check
SDK_INT>28
).I found only the coarse location permission is there when I start a hotspot (through ADB).
Can you help me review this issue? @velitasali Thanks !!!