search

trebleshot / desktop

An Open-Source file sharing software for Linux, macOS and Windows allowing you to send and receive files over available connections, and pause and resume transfer process even when an error is given
GNU General Public License v2.0
33 stars 6 forks source link

Tranfer gets interruped for some files no matter retries #14

Open EmmanuelMess opened 5 years ago

EmmanuelMess commented 5 years ago

PC: Ubuntu 18.04 with Unity 7 linux 4.15 Phone: LG K11α

Transferring a few images, some always fail: imagen And they seem to be always the same photos:

I received these (partial) files (compressed to be able to upload to GitHub).

velitasali commented 5 years ago

Hi @EmmanuelMess, I haven't been able to solve this problem yet. It is happening on my machine as well.

dCo3lh0 commented 5 years ago

Count me in too, i don't know why but if i double-click to restart sending the interrupted file when another file before is running the sending file, sometimes it completes, who knows why, but almost all the times if fails...

EmmanuelMess commented 5 years ago

@velitasali Any ideas on what is the problem?

velitasali commented 5 years ago

@EmmanuelMess There is an ongoing issue with IO during transfer.

On this line, bytesToReceive() always returns a positive number though there is not, creating an issue on the other side of the connection. To prevent that I added checks after that if statement, still, we have issues. https://github.com/genonbeta/TrebleShot-Desktop/blob/24a646a0d392fb2834e0de33a4058ec06882056c/src/broadcast/SeamlessServer.cpp#L159

I am still not sure how to fix that.

EmmanuelMess commented 5 years ago

@velitasali Ok, I don't have much experience with Qt. And I haven't run the code. But, if I may give some advice. Are you compressing, or better, tarring, before sending? So that we can rule out metadata problems.