search

trebleshot / desktop

An Open-Source file sharing software for Linux, macOS and Windows allowing you to send and receive files over available connections, and pause and resume transfer process even when an error is given
GNU General Public License v2.0
33 stars 6 forks source link

Build fixed on Linux Ubuntu 16.04 LTS #16

Closed luav closed 5 years ago

luav commented 5 years ago

Fix for the #15

velitasali commented 5 years ago

Hey, thanks for the work. Can you confirm that these won't cause a problem in the future? I don't own a machine running 16.04, so I am not able to test the best ways to support the previous versions (for native compiling, etc.).

luav commented 5 years ago

You are welcome. You can use a Docker container to perform testing on any platform. Also, you can review the made changes to ensure that they look fine. I just polished your code a bit to avoid compilation errors, which should not affect other platforms, should allow building with older tools and in a more customizable way (automatic identification of the custom Qt installation among several versions). By the way, you can update the CMake requirements in the Readme to 3.2.0+. I set this version in ./CMakeLists.txt in conformance with both qmdnsengine/CMakeLists.txt (requires 3.2.0+) and Qt5 (requires 3.1.0+).

velitasali commented 5 years ago

Alright then. I created another branch to point the previous version.