search

trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.
MIT License
16 stars 21 forks source link

Close #145 - add unit tests for `ProfileServiceImpl` #161

Closed mepox closed 2 years ago

mepox commented 2 years ago

PR Checklist

PR Type

Summary

Add unit tests for ProfileServiceImpl

bglamadrid commented 2 years ago

@mepox please pull changes from main and merge main into your local copy of the branch issue-145 you're pushing here

You may have to resolve some conflicts, and some of your tests will probably fail due to the nature of these latest changes, see #157.

mepox commented 2 years ago

That was an interesting merge, I thought it will only commit the "Merge branch..." but re-commited again my previous commits? Or is this normal? I am not a Git expert.

bglamadrid commented 2 years ago

I'm also learning more about Git workflows as we progress in these latest PRs. I've only used the common merge strategy before. @mepox Your duplicate commits are a result of me squash-merging some PRs to help keep the main commit history tidy. Yet, the result of this experiment ends up a little ugly if not handled with utmost care 😅

If you want to, you can start over the PR to make it easier. Fortunately for you, your changes are quite simple. You would simply have to:

  1. Backup your changes in the ProfileServiceImplTest class and the CHANGELOG note (e.g. copy them outside the repo folder)
  2. Switch to, and pull latest changes in main
  3. Create a new branch from latest main, pour the changes you backed up and commit them
  4. Push the new branch and create your clean PR

Otherwise, if you're not feeling like doing all that, I'm probably squash-merging this PR too to get rid of those pesky duplicate commits 😂

mepox commented 2 years ago

Thanks @bglamadrid , I thought about creating a new PR as a last resort 😄 I was experimenting with Git a bit. I managed to clean up and squash commits... I think 😄

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mepox commented 2 years ago

I wanted to experiment with Git for learning purpose (to able to resolve the mess when needed..). I think this PR is ready now 😄 Please review.

mepox commented 2 years ago

@bglamadrid Of course, let me know if you still want me to create a new clean PR instead.