Close #148 - add unit test for SalesProcessServiceImpl - Githubissues

trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.

MIT License

16 stars 21 forks source link

Close #148 - add unit test for SalesProcessServiceImpl #168

Closed mepox closed 1 year ago

mepox commented 2 years ago

PR Checklist

[x] Read the contribution guidelines
[x] Added a brief description of these changes to the top of the changelog
[x] Changes in code meet test criteria (running mvn test returns exit code 0, without errors)

PR Type

[x] Test-related

Summary

Add unit test for SalesProcessServiceImpl, issue #148

Used @Nested classes to separate the methods
Mock objects were setup at the beginning of each test methods so it's easier to see what are they (no need to scroll up and down)

Thanks @NyorJa for the help how to mock multiple interfaces which uses generics #167

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

mepox commented 1 year ago

Hi @bglamadrid ! I added the comments. Also, I found better to rename that "converterService" so it's clear which convertService is which one. 😄