search

trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.
MIT License
16 stars 21 forks source link

@Override annotations are missing in Data Controllers in `org.trebol.operation.controllers` [codesmell] #169

Closed mepox closed 1 year ago

mepox commented 2 years ago

Code smell says @Override annotations should be used above methods in Data Controllers.

The method is: readMany(@RequestParam Map<String, String> allRequestParams)

The Controllers are:

DataBillingTypesController.java DataCustomersController.java DataImagesController.java DataPeopleController.java DataProductCategoriesController.java DataProductListsController.java DataProductsController.java DataSalesController.java DataSalespeopleController.java DataSellStatusesController.java DataShippersController.java DataUserRolesController.java DataUsersController.java

bglamadrid commented 1 year ago

Hit me up if you want this assigned @mepox, and thanks for reporting it

mepox commented 1 year ago

Hit me up if you want this assigned @mepox, and thanks for reporting it

I will leave it for a bit, in case someone wants it as this is a good first issue.

Prashriya commented 1 year ago

Can I work on this issue?

mepox commented 1 year ago

Hi @Prashriya ! Sure, go ahead.

@bglamadrid Could you please assign @Prashriya ?