search

trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.
MIT License
16 stars 21 forks source link

Update actions version in workflow #172

Closed mepox closed 1 year ago

mepox commented 1 year ago

Line 13:
actions/checkout@v2 to actions/checkout@v3

Line 17: actions/setup-java@v1 to actions/setup-java@v3

Line 21 & 27: actions/cache@v1 to actions/cache@v3

This would remove this warning: Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/setup-java, actions/cache, actions/cache, actions/cache, actions/cache, actions/setup-java, actions/checkout

I tried to send a PR for the changes but it didn't let me 😄

mepox commented 1 year ago

Hi @bglamadrid !

I noticed one more thing in the workflow. You could cache the java part too if you want.

From Line 18:

        with:
          java-version: 11

You could add cache, like this:

        with:
          java-version: 11
          cache: maven

Source: https://github.com/actions/setup-java cache: Quick [setup caching](https://github.com/actions/setup-java#caching-packages-dependencies) for the dependencies managed through one of the predifined package managers. It can be one of "maven", "gradle" or "sbt".