[Sonar] Iterate over the "entrySet" instead of the "keySet" in `src/main/java/org/trebol/config/CorsConfigurationSourceBuilder.java`

trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.

MIT License

16 stars 21 forks source link

[Sonar] Iterate over the "entrySet" instead of the "keySet" in `src/main/java/org/trebol/config/CorsConfigurationSourceBuilder.java` #179

Closed bglamadrid closed 1 year ago

bglamadrid commented 1 year ago

Summary

Source Sonar issue URL
Issue type: Code Smell
Severity: Major
Technical debt: 5min effort

logesr commented 1 year ago

I can work on this issue

bglamadrid commented 1 year ago

@logesr Thanks! Please use the Discussions forums if you have any questions or contact me through my e-mail 👍

mepox commented 1 year ago

Hi @bglamadrid ! I am not sure if this issue was necessary. This file will be deleted soooon.. see #104

bglamadrid commented 1 year ago

@mepox You are correct, but for now it's good to improve on the basics; letting Sonar gives us tips on how to write better code. Also allowing new contributors to step in and contribute with simple tasks.