trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.
MIT License
16 stars 21 forks source link

fix: remove unnecesary condition #190

Closed Angel-M-R closed 1 year ago

Angel-M-R commented 1 year ago

Fixes sonar cloud issue

186

mepox commented 1 year ago

what IDE are you using? it seems you introduce a lot of spaces. The requirement is to remove the null checking for price

I was wondering as well why the whole file has been marked as changed.

bglamadrid commented 1 year ago

Hi @Angel-M-R ! Thank you for your interest in the project. I appreciate your effort and time put into this PR. However I am most curious, just like Nyorja and mepox...

It bugs me that your commit instructs a whole-file overwrite operation. This isn't very good practice; this particular change should be just a few lines of code.

How do you work with Git? Which IDE do you use?

Let's get your PR tidy and organized, shall we?

Angel-M-R commented 1 year ago

Hello im using VS Code, it's been weird for me too view the entire file with changes because i only changed one line, let me try to fix it with other IDE

NyorJa commented 1 year ago

Hello im using VS Code, it's been weird for me too view the entire file with changes because i only changed one line, let me try to fix it with other IDE

Please use Intellij

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

bglamadrid commented 1 year ago

@Angel-M-R As Nyorja said, we highly recommend IntelliJ IDEA, for it has a lot of built-in tooling in place to analyze and improve your Java code.

I also want to give you two another tips.

I learned the second one the hard way; I messed up commit history once. PRs in particular can be squash-merged; you don't have to overwrite your commit history 😉

Regardless of the above, you did a good job. Thank you!