Closed Angel-M-R closed 1 year ago
what IDE are you using? it seems you introduce a lot of spaces. The requirement is to remove the null checking for price
I was wondering as well why the whole file has been marked as changed.
Hi @Angel-M-R ! Thank you for your interest in the project. I appreciate your effort and time put into this PR. However I am most curious, just like Nyorja and mepox...
It bugs me that your commit instructs a whole-file overwrite operation. This isn't very good practice; this particular change should be just a few lines of code.
How do you work with Git? Which IDE do you use?
Let's get your PR tidy and organized, shall we?
Hello im using VS Code, it's been weird for me too view the entire file with changes because i only changed one line, let me try to fix it with other IDE
Hello im using VS Code, it's been weird for me too view the entire file with changes because i only changed one line, let me try to fix it with other IDE
Please use Intellij
Kudos, SonarCloud Quality Gate passed!
@Angel-M-R As Nyorja said, we highly recommend IntelliJ IDEA, for it has a lot of built-in tooling in place to analyze and improve your Java code.
I also want to give you two another tips.
I learned the second one the hard way; I messed up commit history once. PRs in particular can be squash-merged; you don't have to overwrite your commit history 😉
Regardless of the above, you did a good job. Thank you!
Fixes sonar cloud issue
186