trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.
MIT License
16 stars 21 forks source link

fix: change class to protected #191

Closed Angel-M-R closed 1 year ago

Angel-M-R commented 1 year ago

Fixes sonar cloud issue

182

mepox commented 1 year ago

@NyorJa I got illegal modifier error when the class is protected? Was Sonar wrong with this one?

NyorJa commented 1 year ago

@NyorJa I got illegal modifier error when the class is protected? Was Sonar wrong with this one?

Not sure but follow what sonar's recommendation. The only solution is remain it like this public abstract class GenericCrudJpaService<P, E> implements ICrudJpaService<P> { protected GenericCrudJpaService(IJpaRepository<E> repository, ITwoWayConverterJpaService<P, E> converter, Logger logger) { this.repository = repository; this.converter = converter; this.logger = logger; } }

Angel-M-R commented 1 year ago

Changes done @NyorJa

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication