Closed Angel-M-R closed 1 year ago
@NyorJa I got illegal modifier error when the class is protected? Was Sonar wrong with this one?
@NyorJa I got illegal modifier error when the class is protected? Was Sonar wrong with this one?
Not sure but follow what sonar's recommendation. The only solution is remain it like this public abstract class GenericCrudJpaService<P, E> implements ICrudJpaService<P> { protected GenericCrudJpaService(IJpaRepository<E> repository, ITwoWayConverterJpaService<P, E> converter, Logger logger) { this.repository = repository; this.converter = converter; this.logger = logger; } }
Changes done @NyorJa
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Fixes sonar cloud issue
182