trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.
MIT License
16 stars 21 forks source link

fix: sonar issue always false #193

Closed Angel-M-R closed 1 year ago

Angel-M-R commented 1 year ago

Fixes sonar cloud issue

184

mepox commented 1 year ago

Please check formatting

Where exactly? Empty Line in 66, 68 and 71?

NyorJa commented 1 year ago

Please check formatting

Where exactly? Empty Line in 66, 68 and 71?

Not exactly the specific line but the whole class itself introduce a new format. I'm not sure if it follows 2 spaces

Angel-M-R commented 1 year ago

Hello @NyorJa could you check please?

mepox commented 1 year ago

Please remove the failing test in CustomersConverterJpaServiceImplTest (Line 53) that was related to raising a BadInputException when this condition was true.

Good catch, sorry 😄 I actually manually pulled the PRs and ran mvn test but I probably skipped this one..... 😐

Angel-M-R commented 1 year ago

Done, thank you @bglamadrid

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information