Closed logesr closed 1 year ago
Kudos, SonarCloud Quality Gate passed!
Hi @logesr! Thanks for your contribution.
I'm a little concerned though, these commits are forcing a whole-file overwrite operation, yet these changes should just span a couple lines of code.
What IDE do you use? How do you work with Git?
Hi @NyorJa and @bglamadrid, I am using intellij IDEA. Not sure how these spaces came in. Will check it out
Thank you for coming back to us @logesr
It still bothers me that this PR overwrites the entirety of the files involved.
I know this may take some time, but can you please start over?
Backup these files, checkout main
, create a new branch, paste your backup files on it, commit, push and create a new PR just like this one.
If that PR performs just the intended changes then I'll be sure to merge it 👍
Sure thing @bglamadrid. Will create a new pull request
PR Checklist
mvn test
returns exit code 0, without errors)PR Type
Summary
Used entrySet in place of keySet which serves better in this purpose when we iterate to get both key and value. Closes #179
Additional info