Used entrySet in place of keySet

trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.

MIT License

16 stars 21 forks source link

Used entrySet in place of keySet #202

Closed logesr closed 1 year ago

logesr commented 1 year ago

PR Checklist

[x] Read the contribution guidelines
[x] Added a brief description of these changes to the top of the changelog
[x] Changes in code meet test criteria (running mvn test returns exit code 0, without errors)

PR Type

[x] Refactoring (changes that do not affect API nor functionality)

Summary

Used entrySet in place of keySet which serves better in this purpose when we iterate to get both key and value. Closes #179

Additional info

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

bglamadrid commented 1 year ago

Hi @logesr! Thanks for your contribution.

I'm a little concerned though, these commits are forcing a whole-file overwrite operation, yet these changes should just span a couple lines of code.

What IDE do you use? How do you work with Git?

logesr commented 1 year ago

Hi @NyorJa and @bglamadrid, I am using intellij IDEA. Not sure how these spaces came in. Will check it out

bglamadrid commented 1 year ago

Thank you for coming back to us @logesr

It still bothers me that this PR overwrites the entirety of the files involved.

I know this may take some time, but can you please start over? Backup these files, checkout main, create a new branch, paste your backup files on it, commit, push and create a new PR just like this one. If that PR performs just the intended changes then I'll be sure to merge it 👍

logesr commented 1 year ago

Sure thing @bglamadrid. Will create a new pull request