[Sonar] Remove this null check which always evaluates to "false" in `src/main/java/org/trebol/jpa/services/crud/SalespeopleJpaCrudServiceImpl.java` - Githubissues

trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.

MIT License

16 stars 21 forks source link

[Sonar] Remove this null check which always evaluates to "false" in `src/main/java/org/trebol/jpa/services/crud/SalespeopleJpaCrudServiceImpl.java` #215

Closed mepox closed 1 year ago

mepox commented 1 year ago

Source Sonar issue URL
Issue type: Bug
Severity: Major
Technical debt: 5min effort

mepox commented 1 year ago

@Valid annotations are missing on the parameters?

https://github.com/trebol-ecommerce/spring-boot-backend/blob/3b07112388854b6c7a4003ea2de381ebb12cd2bd/src/main/java/org/trebol/operation/controllers/AccountProfileController.java#L53

https://github.com/trebol-ecommerce/spring-boot-backend/blob/3b07112388854b6c7a4003ea2de381ebb12cd2bd/src/main/java/org/trebol/operation/controllers/DataSalespeopleController.java#L71-L77

Added to new issues #220 and #221

mepox commented 1 year ago

False positive