search

trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.
MIT License
16 stars 21 forks source link

[Sonar] Remove this expression which always evaluates to "true" in `src/main/java/org/trebol/jpa/services/conversion/UserRolesConverterJpaServiceImpl.java` #216

Closed mepox closed 1 year ago

mepox commented 1 year ago

Instead of name != null && !name.isBlank() use StringUtils.isNotBlank

mepox commented 1 year ago

@Valid annotation should be used on the parameter:

https://github.com/trebol-ecommerce/spring-boot-backend/blob/3b07112388854b6c7a4003ea2de381ebb12cd2bd/src/main/java/org/trebol/operation/controllers/DataUserRolesController.java#L73

Opened new issue for this #219

bglamadrid commented 1 year ago

This issue is no longer present in the current version of UserRolesConverterJpaServiceImpl, so I am closing it.