search

trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.
MIT License
16 stars 21 forks source link

Add null check back for sourcePerson in `src/main/java/org/trebol/jpa/services/conversion/CustomersConverterJpaServiceImpl.java` #223

Closed mepox closed 1 year ago

mepox commented 1 year ago

@bglamadrid @NyorJa Null check got removed in PR #193 , so after our discussion, should this added back then? If yes, I will open another issue for the other similar PR, which is #190

bglamadrid commented 1 year ago

No. Services from package org.trebol.jpa.services.conversion are about to change due to refactoring in #227 This issue is going stale when that happens.

In that PR, the applyChangesToExistingEntity method used to belong to this service, but that has been moved to a new one altogether; CustomersDataTransportJpaServiceImpl.

I've said before want to document this project better, and here's one important thing to note. Services in package org.trebol.jpa.services.crud are the ones responsible for these kinds of validations. Other services in packages like conversion, must be designed dumber. So they are to assume all validations are made outside of their scope.

Thanks for asking @mepox 👌

bglamadrid commented 1 year ago

Closing this issue for the reasons stated above.