search

trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.
MIT License
16 stars 21 forks source link

Remove unnecessary line in `AccountProfileController` #225

Closed mepox closed 1 year ago

mepox commented 1 year ago

String username = principal.getName(); is unnecessary here.

https://github.com/trebol-ecommerce/spring-boot-backend/blob/91af6a3447d69a16cdb1c7e5dc5509fbf2110357/src/main/java/org/trebol/operation/controllers/AccountProfileController.java#L55-L56

bglamadrid commented 1 year ago

I suggest to change the parameter passed in updateProfileForUserWithName to the username variable, instead of deleting its declaration and assignment.

bglamadrid commented 1 year ago

Closed in #229