Closed mepox closed 1 year ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
mepox, I have a reason to keep this PR unmerged, please do mind me.
If you navigate through the update
method call chain, you'll find that eventually it is assumed that most properties in every object are nullable. Unlike an actual object that would be @Valid
. This is by design (a bad design made by me obviously lol), so you don't have to worry about it for now.
@mepox this PR is also conflicting now, but at least it should be easy to resolve.
Sorry @mepox, I ended up doing a mess of this PR due to another PR of my own #244. I'll have to close it because it's too complicated to resolve these conflicts now, and there's no point in overtaking such a heavy task.
If you want you can still create another PR, I'm not going to close the issues you were targetting here just yet.
PR Checklist
mvn test
returns exit code 0, without errors)PR Type
Summary
Add missing @Valid annotations in the following Controllers:
src/main/java/org/trebol/operation/controllers/DataSalespeopleController.java
src/main/java/org/trebol/operation/controllers/AccountProfileController.java
src/main/java/org/trebol/operation/controllers/DataUserRolesController.java
Additional info
Close #219, Close #220, Close #221