Closed bglamadrid closed 1 year ago
It seems there are failed test in this PR @bglamadrid
I know, thanks for the heads up @NyorJa
Just wanted to submit this now as a sort of warning token; see how many files I'm updating here. Hopefully no one touches these. Otherwise, merge conflicts will be a real pain. 😆
Kudos, SonarCloud Quality Gate passed!
PR Checklist
mvn test
returns exit code 0, without errors)PR Type
Summary
Reduced complexity of several classes in the
org.trebol.jpa.services
package by extracting a method out of theITwoWayConverterJpaService
interface into a newIDataTransportJpaService
interface. It also affects other classes that interact with these two interfaces.This was a very needed change because the interaction between the
crud
andconverter
services was very confusing, specially for theProductCategory
andSell
entities which have some interesting quirks (the former can be linked to a parent of its own type and even cascade a whole category tree, while the latter has a lot of relationships to several other entities). It was hard to draw the line of responsibility while creating and updating data related to these.This refactor basically aims to make the algorithms for CRUD operations much more streamlined and easy to follow.
Unit tests are being refactored accordingly. Yet, at the time of writing (and editing), these remain broken and must be fixed.
Closes #116