search

trebol-ecommerce / trebol-backend-monolith

Monolithic eCommerce backend web application that exposes a RESTful API.
MIT License
16 stars 21 forks source link

Document incompatible JDKs #258

Closed bglamadrid closed 1 year ago

bglamadrid commented 1 year ago

Summary

I just tried and found out that under JDK19, the compilation of this app is broken.

It would be good to know if other versions newer than 11 are incompatible as well.

Expected outcome

A JDK compatibility list added to the README, near the Requirements section.

Additional note

JDKs can be downloaded from many several places, given the current state of Java (distributed akin to Linux).

Check this link to know more, and also to find the recommended one for your system.

mslowiak commented 1 year ago

Hi @bglamadrid . Can I work on this?

bglamadrid commented 1 year ago

Hi @bglamadrid . Can I work on this?

Hi there. Why, of course! Do you have any questions?

Funny, I was just writing this one and you stumbled here eagerly hehee

bglamadrid commented 1 year ago

There @mslowiak, I assigned you the issue. Let me know if there's anything you need assistance with!

mslowiak commented 1 year ago

Haha yeah, your issue appeared directly as a first issue in the search results :D

Let me know if there's anything you need assistance with!

Will do if I will stuck somewhere, thanks!

mslowiak commented 1 year ago

Hey @bglamadrid!

I checked all versions between 11-21. Looks like compatibility is broken for 19+ - I raised the PR with documentation

Project uses the Spring 2.x - I think regarding to their release notes that JDK 19 is supported starts from 3.x

bglamadrid commented 1 year ago

Hey @bglamadrid!

I checked all versions between 11-21. Looks like compatibility is broken for 19+ - I raised the PR with documentation

Project uses the Spring 2.x - I think regarding to their release notes that JDK 19 is supported starts from 3.x

Awesome. The way you phrased this last bit also made me curious, so I went ahead and searched their repo to find this little bit of documentation on the matter, quote:

Spring Boot 3.2.0-SNAPSHOT requires Java 17 and is compatible up to and including Java 21. Spring Framework 6.1-SNAPSHOT or above is also required.

And given their versioning scheme in their github repo, I managed to find this for v2.6.x:

Spring Boot 2.6.15 requires Java 8 and is compatible up to and including Java 19. Spring Framework 5.3.27 or above is also required.

And for v2.7.x, too:

Spring Boot 2.7.16 requires Java 8 and is compatible up to and including Java 20. Spring Framework 5.3.30 or above is also required.

So yeah, I did not know there was a newer minor version of 2.x, nor that it is even compatible with up to Java 20. So there go some more issues to deal with later on.

Thanks so much @mslowiak!