search

tree-sitter-grammars / tree-sitter-hare

Hare grammar for tree-sitter
MIT License
10 stars 2 forks source link

FIX: global declarations were error nodes #7

Open leath-dub opened 1 month ago

leath-dub commented 1 month ago

Small error in the grammar, the hare compiler allows implicit type in globals. Just changed the type param to be optional(seq(":", $.type)).

I also regenerated the bindings, not sure what the general convention for pr's is.

clason commented 1 month ago

I also regenerated the bindings, not sure what the general convention for pr's is.

In general, PRs (and certainly commits) should stick to their declared purpose. Unless needed, use tree-sitter generate --no-bindings (and be careful about using pre-release commits! always stick to the latest release) and leave binding updates to a dedicated "chore" PR or commit (if needed to get tests to pass).