add actual choices to avoid code generation errors in ocaml-tree-sitter-semgrep

tree-sitter-grammars / tree-sitter-hcl

HCL grammar for tree-sitter

https://tree-sitter-grammars.github.io/tree-sitter-hcl/

Apache License 2.0

92 stars 20 forks source link

add actual choices to avoid code generation errors in ocaml-tree-sitter-semgrep #7

Closed aryx closed 3 years ago

MichaHoffmann commented 3 years ago

Hey,

first of all thanks for the PR!

I think it would be better to just take out the template_directive rule completely for now as its a no-op anyway. I'm currently working on implementing those but am progressing slowly because of work.

MichaHoffmann commented 3 years ago

Also i'm thinking, should we add a github action to ensure that your project can be built with this library? I added some actions for nvim-treesitter a few months ago. Does not have to be on this PR though. What do you think?

aryx commented 3 years ago

Ok, I made another PR.