search

tree-sitter-grammars / tree-sitter-markdown

Markdown grammar for tree-sitter
MIT License
375 stars 45 forks source link

Revert "Add Swift accessors for scm resources" #88

Closed jsorge closed 1 year ago

jsorge commented 1 year ago

I was discussing this with @mattmassicotte just after I opened the PR and he's concerned this is going to break a lot of clients in the wild because of the change to the Swift packages here, so it sounds like it's best to revert for now.

So sorry!

MDeiml commented 1 year ago

Sorry from my side too. Should have waited for your answer.

MDeiml commented 1 year ago

Is there a safe way for doing this though?

mattmassicotte commented 1 year ago

Just to add some context - I love the idea of this change. The issue is this makes the markdown parser special in a way that a) will break existing users and b) will be a lot of work to copy to other SPM-enabled parsers. So, while this is good, I think it makes more sense to keep the binding very uniform and move special logic into higher-levels.

MDeiml commented 1 year ago

Ok. Thanks for your insight