Updates - Githubissues

tree-sitter-grammars / tree-sitter-query

TS query grammar for tree-sitter

Apache License 2.0

52 stars 14 forks source link

Updates #36

Closed amaanq closed 5 months ago

amaanq commented 5 months ago

Mostly changes I consider to be more correct/appropriate

clason commented 5 months ago

That's not a lot to go on... Can you please explain the changes and why they are more appropriate?

(Remember that this parser is a crucial bundled part of the Neovim infrastructure now, so I have to be extra careful.)

amaanq commented 5 months ago

Yeah sure, sorry

Rename list to alternation, it's the correct term
Add string_content to strings, it's useful for injecting/extracting the content
- Make definition a supertype, it's still hidden from the parse tree but is queryable and makes more sense for it
- Also don't alias string to identifier for unnamed nodes, that made no sense imo, you're hiding info that distinguishes them (one might assume it's structured like a normal identifier, this is not true)

clason commented 5 months ago

Indent queries have to be adapted too. And please test the effect on the builtin query linter and -- especially -- on nvim-treesitter's format-queries.

clason commented 5 months ago

Ok, I think I have to put on the brakes here; I really don't like "Updates: things I like better". Can you separate each of these changes into individual PRs (marked refactor or feat or feat! for semver purposes) so we can review, discuss and (for non-breaking improvements) merge separately?

(And yes, that means generating the parser for each change. I strongly believe that if you track parser.c, it should be consistent with the repo state -- otherwise bisecting becomes impossible.)

amaanq commented 5 months ago

Superseded by 37, 38, 39