search

tree-sitter / haskell-tree-sitter

Haskell bindings for tree-sitter
149 stars 45 forks source link

Add C# language support #276

Closed damieng closed 4 years ago

damieng commented 4 years ago

Add's C# support here in order to get closer to C# semantic code support on GitHub.com

Not sure how to test this locally but the CI/GH Actions are passing including running the corpus tests.

Let me know if anything else needs to happen either on this repo, tree-sitter-c-sharp or elsewhere!

Fixes #185

damieng commented 4 years ago

Okay to merge?

aymannadeem commented 4 years ago

Fine by me

damieng commented 4 years ago

Should I create a PR for a version bump and change-log ?

patrickt commented 4 years ago

Since this is the first version, we shouldn’t need any changeling updates: we should just do the rest of the steps in the release process and pop it up on Hackage.

damieng commented 4 years ago

Do you need me to do those steps or is the "we" github?

patrickt commented 4 years ago

@damieng I think for now @tree-sitter/semantic-code should own the tree-sitter packages, though we’ll be happy to add you alongside, since you did the work!

For now, you can depend on the new package directly as a pinned git version in the cabal.project file in Semantic. That should unblock you on subsequent steps (creation of semantic-c-sharp, etc.).