The Linux binaries that are created on Travis are causing problems for the Atom build. For the last two releases, I've had to delete the prebuilt Linux binaries in order to get the Atom Travis builds to pass.
I think the problem may be that these binaries are compiled with gcc. Atom uses clang, and so does node-keytar, Atom's other native dependency with prebuild support. Clang and gcc create binaries with dependencies on two different C++ standard library implementations.
For now, I'm going to switch the node-tree-sitter builds to also use clang on Linux. Hopefully this ends up working for all Linux users. If it ends up breaking people with gcc, we're going to have to just stop using prebuild at all on Linux.
nathansobo
commented
5 years ago
The Linux binaries that are created on Travis are causing problems for the Atom build. For the last two releases, I've had to delete the prebuilt Linux binaries in order to get the Atom Travis builds to pass.
I think the problem may be that these binaries are compiled with gcc. Atom uses clang, and so does
node-keytar, Atom's other native dependency withprebuildsupport. Clang and gcc create binaries with dependencies on two different C++ standard library implementations.For now, I'm going to switch the
node-tree-sitterbuilds to also use clang on Linux. Hopefully this ends up working for all Linux users. If it ends up breaking people with gcc, we're going to have to just stop using prebuild at all on Linux./cc @wingrunr21 @rafeca @nathansobo