search

tree-sitter / node-tree-sitter

Node.js bindings for tree-sitter
https://www.npmjs.com/package/tree-sitter
MIT License
649 stars 114 forks source link

Use C++14 to allow building for Electron 11 on MacOS #83

Closed sergei-dyshel closed 3 years ago

sergei-dyshel commented 3 years ago

Fixes https://github.com/tree-sitter/node-tree-sitter/issues/82.

Symbolk commented 3 years ago

@maxbrunsfeld Could this be merged and released? A timely change for me.

jinu-jang commented 3 years ago

This is just necessary for recent electron versions (v11, v12) @sergei-dyshel thanks for the fix. This at least got me unblocked for now

Symbolk commented 3 years ago

Right, for those who use electron v11+, here is the manual instruction to rebuild this module:

https://github.com/Symbolk/somanyconflicts#known-issues

DeeDeeG commented 3 years ago

:+1:, and I think not merging this might slow progress on using Electron 11 in the Atom text editor. Might have to fork this package for Atom just to get it building in Electron 11.

sadick254 commented 3 years ago

@maxbrunsfeld What could be holding back this PR from getting merged? As @DeeDeeG has stated this currently blocks Atom from upgrading to electron version 11.4.7.

Symbolk commented 3 years ago

After being torture by native module (node-gyp and electron-rebuild) for months, I finally switched to wasm of treesitter, and it seems working fine: https://github.com/Symbolk/somanyconflicts

Maybe this solution helps some of you.

verhovsky commented 3 years ago

This PR can be closed because #92 (merged) did the same thing.