search

tree-sitter / tree-sitter-c-sharp

C# Grammar for tree-sitter
MIT License
177 stars 47 forks source link

Support for do and while loops named fields #324

Closed GeekMasher closed 7 months ago

GeekMasher commented 7 months ago

This pull request added support for the body and condition named fields for both do and while loops. This will make it easier to identify which field is which.

damieng commented 7 months ago

Hi there, thanks for the PR.

It looks like the tests weren't updated to reflect the changes?

npm run test will run those tests and show you how the output has changed. If it looks right then you can update the text file to match.

(You can do npm run test-windows if you just want to run the corpus tests without the full CI parsing of third-party projects test suite)

GeekMasher commented 7 months ago

Thanks @damieng, let me do this now

GeekMasher commented 7 months ago

Should be fixed now @damieng, let me know if you need me to update anything else.

Edit: I had to update the scripts/file_sizes.txt file as it changed, hope that works

damieng commented 7 months ago

Thanks for your contribution!