tree-sitter / tree-sitter-cli

CLI tool for creating and testing tree-sitter parsers
MIT License
45 stars 15 forks source link

Which version should I stick to? #37

Closed banacorn closed 6 years ago

banacorn commented 6 years ago

Packages such as tree-sitter-python and tree-sitter-ruby have upgraded to tree-sitter-cli@0.13.x. I've also upgrade tree-sitter-agda to tree-sitter-cli@0.13.x and published it.

Everything looks fine ... until I switched to the development mode on Atom 1.29.0 , where I would get error messages like:

RangeError: Incompatible language version. Expected 8. Got 9

I've encountered this problem before and I've noticed that Atom 1.29.0 is using tree-sitter-cli@0.12.12. So as I downgraded my tree-sitter-cli to 0.12.12, the incompatible language version problem went away as expected.

However, I still have a few questions:

Aerijo commented 6 years ago

If this is about Atom, see https://github.com/atom/atom/issues/17777

banacorn commented 6 years ago

Thank you @Aerijo, it definitely has something to do with Atom's versions.

But this is what is confusing me:

Why?

maxbrunsfeld commented 6 years ago

But this is what is confusing me: Atom 1.29 production mode: works with tree-sitter@0.13.x Atom 1.29 development mode: works with tree-sitter@0.12.x

I don't think that's true. Dev mode has nothing to do with the Tree-sitter ABI version. It's probably just that when you're running Atom in --dev mode, it's probably running different code than what's in Atom 1.29.

@banacorn I'm going to close this out since it's about Atom. If you have further questions, see the issue that @Aerijo mentioned.