search

tree-sitter / tree-sitter-embedded-template

Tree-sitter grammar for embedded template languages like ERB, EJS
MIT License
60 stars 18 forks source link

Highlighting Not Working on GitHub.com #27

Closed davidmurdoch closed 2 months ago

davidmurdoch commented 8 months ago

I was told this package was used for GitHub.com's syntax highlighting. Please close this if this isn't true.

I've added a .gitattributes linguist-language mapping for app's HTML files to EJS: https://github.com/MetaMask/metamask-extension/blob/0495d5b395bab9f3ec954cdcac84aaf085fc7f98/.gitattributes#L24

But the HTML files aren't syntax highlighted as I'd expect. Example file that lacks EJS syntax highlighting: https://github.com/MetaMask/metamask-extension/blob/0cd76e5b6a3fe4b491348ac0c348a27a82368a32/app/home.html#L6-L10

amaanq commented 2 months ago

Issues shouldn't be opened here for GH's usage of tree-sitter, it's probably better to do that at linguist.