search

tree-sitter / tree-sitter-go

Go grammar for tree-sitter
MIT License
317 stars 63 forks source link

Fixes #126

Closed amaanq closed 1 year ago

amaanq commented 1 year ago

Mostly just prep for a new release

Closes #53

aryx commented 1 year ago

It would be better to separate the changing indentation, adding CI, ... from the actually grammar fix, otherwise it's hard to review. I'm ok with 1 single PR that does the indentation fix/adding CI/... but at least make a separate PR for the grammar change.

amaanq commented 1 year ago

Normally I would - but I only changed one item by adding one character to it (null character for terminator, and you can see the change by clicking on that commit), I just found it a bit too insignificant to separate, sorry about that

amaanq commented 1 year ago

Also gonna add on that the problem could've been solved using dynamic precedence and setting qualified identifiers to -1, so that call_expression is preferred over that

Wilfred commented 1 year ago

@amaanq FWIW this introduces a compiler warning when compiling tree-sitter-go, but I think it's an issue with tree-sitter proper: https://github.com/tree-sitter/tree-sitter/issues/2490

amaanq commented 1 year ago

Thanks for the report! I noticed that too so - this should fix it when ready:

https://github.com/tree-sitter/tree-sitter/pull/2488