Tolerate unescaped newlines in string literals

tree-sitter / tree-sitter-javascript

Javascript grammar for tree-sitter

MIT License

318 stars 107 forks source link

Tolerate unescaped newlines in string literals #140

Closed mjambon closed 3 years ago

mjambon commented 3 years ago

This is useful for typescript and is considered not harmful in javascript given the scope of the tree-sitter project.

This PR is a follow-up to https://github.com/tree-sitter/tree-sitter-typescript/pull/91

mjambon commented 3 years ago

This should be good to merge!

mjambon commented 3 years ago

Hi @maxbrunsfeld, we'd like to merge this. We've been using it in prod for a while and it works fine. I just updated the generated code for mergeability.

maxbrunsfeld commented 3 years ago

Thanks!

mjambon commented 3 years ago

Thank you Max!