0.20 - Githubissues

tree-sitter / tree-sitter-javascript

Javascript grammar for tree-sitter

MIT License

323 stars 109 forks source link

0.20 #202

Closed Luni-4 closed 2 years ago

Luni-4 commented 2 years ago

Checklist:

[x] All tests pass in CI.
[ ] The script/parse-examples passes without issues.
[ ] There are sufficient tests for the new fix/feature.
[ ] Grammar rules have not been renamed unless absolutely necessary.
[ ] The conflicts section hasn't grown too much.
[ ] The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

This PR updates tree-sitter-javascript to 0.20

@maxbrunsfeld

Can we release it on crates.io also? Thanks in advance! :)

aryx commented 2 years ago

@mjambon which version of tree-sitter are we using currently in ocaml-tree-sitter-semgrep?

mjambon commented 2 years ago

What's the motivation for this change, @Luni-4 ? My understanding is that the version constraint ^0.19.0 allows tree-sitter 0.20.0, but ^0.20.0 doesn't allow tree-sitter 0.19.0.

mjambon commented 2 years ago

I wrote:

My understanding is that the version constraint ^0.19.0 allows tree-sitter 0.20.0, but ^0.20.0 doesn't allow tree-sitter 0.19.0.

Sorry, I was wrong because 0. is not a real major version. https://github.com/npm/node-semver#caret-ranges-123-025-004