search

tree-sitter / tree-sitter-javascript

Javascript grammar for tree-sitter
MIT License
318 stars 107 forks source link

[bug] tree-sitter-javascript build fails on Windows #316

Closed HerringtonDarkholme closed 3 weeks ago

HerringtonDarkholme commented 3 weeks ago

'/Wno-unused-parameter' is not supported on Windows.

Example: https://github.com/ast-grep/ast-grep/actions/runs/8982614704/job/24670617449

image

Realted code

https://github.com/tree-sitter/tree-sitter-javascript/blob/master/bindings/rust/build.rs#L4-L6

Related commit

https://github.com/tree-sitter/tree-sitter-javascript/commit/3d0c5b7cdff2a1f4edc5f0e307f345edee07ef60#diff-d22828e5b7e30d7789ad02ea628483b68bb146a0cb051f920821d2ac077b6bbfL10

image

Proposal: use flag_if_supported