search

tree-sitter / tree-sitter-python

Python grammar for tree-sitter
MIT License
374 stars 138 forks source link

Include <stdint.h> for e.g. UINT16_MAX etc. #218

Closed he32 closed 1 year ago

he32 commented 1 year ago

This is required at least on NetBSD, and should in theory not hurt on other platforms, so is not done conditionally.

siyath123 commented 1 year ago

Action

he32 commented 1 year ago

For reference, this problem was experienced with version 0.20.0.

amaanq commented 1 year ago

For reference, this problem was experienced with version 0.20.0.

So it's fine with 0.20.8 now, right?

he32 commented 1 year ago

It's a little unclear what constitutes 0.20.8, the newest tag in the github repository is v0.20.0. That said, in HEAD, src/scanner.cc has apparently been replaced with src/scanner.c, which includes , so it seems there have been made changes which possibly and probably invalidates the bug report.

I would like to encourage you to mark your 0.20.8 release with a tag, it would make it easier for me to verify that the bug is indeed no longer applicable.

amaanq commented 1 year ago

I see, I thought you meant errors when generating with 0.20.0 of tree-sitter itself, I agree that we should update our releases.

clason commented 1 year ago

...using semver 😇

amaanq commented 1 year ago

There is now a new release @0.20.3