search

tree-sitter / tree-sitter-ruby

Ruby grammar for tree-sitter
MIT License
176 stars 58 forks source link

Ruby parser.c size #223

Closed bkramer-relyance closed 1 year ago

bkramer-relyance commented 2 years ago

The Ruby parser seems to generally work well, and if it takes an oversized parse table to drive it, then okay. However, doing git clone of the Tree sitter repo, especially on CI/CD environments, seems to take an unfair amount of time. One way this could be mitigated by compressing parser.c. Any thoughts?

ojab commented 1 year ago

Hot take: it's autogenerated, so shouldn't reside in the repo and should be generated on as-needed basis, like for release tarballs.

dcreager commented 1 year ago

This has come up before not just for the Ruby grammar; please see https://github.com/tree-sitter/tree-sitter/discussions/1243 for additional discussion. The current plan is to stop checking in the generated files as part of a 1.0 release of tree-sitter.

Ben3eeE commented 1 year ago

Closing in favor of https://github.com/tree-sitter/tree-sitter/issues/930