search

tree-sitter / tree-sitter-ruby

Ruby grammar for tree-sitter
MIT License
176 stars 58 forks source link

Allow invocations of indexes to accept block arguments. #257

Closed TreyE closed 2 months ago

TreyE commented 3 months ago

Indexing of elements in Ruby is really just an invocation of the [] method on an object. As such, element indexing should accept a block.

The pull request contains tests as well as an extension of the grammar.

TreyE commented 2 months ago

Wow, so we're just gonna grab my code and submit it as your own under PR #262 @hvitved ? Not even a mention on the original PR?

Very uncool.

I don't care about the credit, but a thanks would have been nice. At the very least you could have closed the PR so it doesn't stay open instead of ignoring it entirely.

@amaanq is this the normal submission process? Because if contributions are going to just be taken without any kind of attribution I'll just stop now - and I'll let my colleagues know to do the same.

hvitved commented 2 months ago

Sorry, I had forgotten to look at already open PRs before submitting my fix (which was needed for https://github.com/github/codeql/issues/16757).

amaanq commented 2 months ago

Hey @TreyE, I am really sorry for not noticing the open PR as well - the Ruby grammar is one I do not check in on as much as the others, so I hadn't seen you PR in the same fix here, and I saw hvitved's because he pinged me.

Going forward I'll be sure to double check all open PRs to avoid that happening again, really sorry. I would still appreciate any and all fixes/improvements you want to make (if you are still interested, understandable if you are not), and feel totally free to just ping me to take a look :slightly_smiling_face: