search

tree-sitter / tree-sitter-rust

Rust grammar for tree-sitter
MIT License
357 stars 101 forks source link

feat: support CStr literals #202

Closed GoldsteinE closed 1 year ago

GoldsteinE commented 1 year ago

Given that FCP vote is started on https://github.com/rust-lang/rust/pull/117472 and it’s likely to hit stable soon-ish, I think it’s time to support c"foo" and cr#"foo"# in tree-sitter-rust.

This PR contains a lot of irrelevant changes in auto-generated files which I’m not sure how to handle. Is there a standardized environment to regenerate those?

amaanq commented 1 year ago

I made some changes on master so I'm just going to remove your generation changes, merge this, then regenerate all the changes at once (way fewer changes added to the git history this way instead of generating per change)

Typically a PR alone would just generate and commit the generated files too, and those do matter for downstream consumers that don't want to have a dependency on the CLI, but that being said generating using tree-sitter's cli built from master is the way to go (you'll notice changes to header files that shouldn't have happened because of that)

Thanks for your contribution and lmk if you have any more questions