Closed resolritter closed 3 years ago
looking forward to this merge
Would be awesome if this got merged.
Just wanted to check in to see if there was a chance of this one getting merged soon? The parse tree gets pretty messed up without it 😅
@resolritter a merge conflict is reported by github in common/define-grammar.js
. Hopefully it's not a big deal. Let us know if you need someone to take over.
In the past I was discouraged to work on the grammars because I saw plenty of PRs rot away without being merged. e.g. https://github.com/tree-sitter/tree-sitter-rust/pulls has plenty of those. Nowadays I'm too busy to keep rebasing the PRs constantly without any prospect of having them be merged. I suppose this repository has a better situation than the other grammars since @mjambon takes care of them.
I'll should have room to revisit this on the weekend or something, but if someone wants to take over, feel free.
@mjambon The PR was rebased and should be ready. It might be worthwhile taking a look at https://github.com/tree-sitter/tree-sitter-typescript/pull/138#pullrequestreview-754176173 because I'm not familiar with the (string_fragment)
.
@resolritter a string_fragment
node represents string contents, which used to be hidden. You did the right thing.
:rocket:
:exclamation: on top of #135 for convenience's sake; there's no apparent code dependency between them. I can try to split the relevant commits for #136 (named
implement template literal types
) and #137 (namedimplement "mapped type 'as' clasues"
) upon demand.closes #137
closes #136