tree-sitter / tree-sitter-typescript

TypeScript grammar for tree-sitter
MIT License
341 stars 104 forks source link

Regenerate files, which hadn't picked up the correct version of tree-sitter-javascript #168

Closed mjambon closed 3 years ago

mjambon commented 3 years ago

npm is still a mystery to me. I never know what to invoke to update dependencies.

In {tsx,typescript}/src/grammar.json, I looked for private_property_identifier which is a recent addition to tree-sitter-javascript. It's now present, so I assume this time I did the right thing.

Originally, I had just modified package.json by hand, followed by npm install. I suppose this is deeply wrong since the generated grammar.json still inherited from the older tree-sitter-javascript grammar.

This time, I did this:

npm install github:tree-sitter/tree-sitter-javascript#ae9bc67

followed by

npm run build
npm test

I think code generation should be automated to avoid this kind of problems.

Checklist:

mjambon commented 3 years ago

Merging this since it's only generated code.