Update tree-sitter-javascript to 2cc5803 - Githubissues

tree-sitter / tree-sitter-typescript

TypeScript grammar for tree-sitter

MIT License

342 stars 104 forks source link

Update tree-sitter-javascript to 2cc5803 #190

Closed ruricolist closed 2 years ago

ruricolist commented 2 years ago

Pursuant to #189.

This is not the most recent version, but updating beyond 2cc5803 will be much more involved, as after that point the external scanner was rewritten and the underlying tree-sitter version upgraded.

(I have also rewritten the external scanner for TypeScript to match the changes to the JavaScript scanner, but while it passes the test suite it causes the number of failed examples to jump from 24 to 35.)

Checklist:

[x] All tests pass in CI.
[x] There are sufficient tests for the new fix/feature.
[x] Grammar rules have not been renamed unless absolutely necessary.
[x] The conflicts section hasn't grown too much.
[x] The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

mjambon commented 2 years ago

Thank you. Let's merge this but I have questions regarding the maintenance of tree-sitter-javascript and tree-sitter-typescript. I'll open an issue.

--> #191